Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8170720: VetoableListDecorator: Indexes to remove are not aggregated #1675

Closed
wants to merge 2 commits into from
Closed

8170720: VetoableListDecorator: Indexes to remove are not aggregated #1675

wants to merge 2 commits into from

Conversation

mstr2
Copy link
Collaborator

@mstr2 mstr2 commented Jan 14, 2025 •
edited by openjdk bot
Loading

VetoableListDecorator does not correctly report removed indices. Instead of reporting ranges like [0, 3), it always reports a pairwise list of single removals like [0, 1, 1, 2, 2, 3).

The reason is a off-by-one error, and the fix is simple.

/reviewers 2

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8170720: VetoableListDecorator: Indexes to remove are not aggregated (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1675/head:pull/1675
$ git checkout pull/1675

Update a local copy of the PR:
$ git checkout pull/1675
$ git pull https://git.openjdk.org/jfx.git pull/1675/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1675

View PR using the GUI difftool:
$ git pr show -t 1675

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1675.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 14, 2025

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 14, 2025 •
edited
Loading

@mstr2 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8170720: VetoableListDecorator: Indexes to remove are not aggregated

Reviewed-by: lkostyra, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Ready for review label Jan 14, 2025
@openjdk
Copy link

openjdk bot commented Jan 14, 2025

@mstr2
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented Jan 14, 2025

Webrevs

@kevinrushforth kevinrushforth self-requested a review January 14, 2025 17:36
lukostyra
lukostyra approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@lukostyra lukostyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fix is trivial and tests all work as intended

kevinrushforth
kevinrushforth approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I confirm that the added tests fail without and pass with the fix.

@openjdk openjdk bot added the ready Ready to be integrated label Jan 24, 2025
@mstr2
Copy link
Collaborator Author

mstr2 commented Jan 24, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 24, 2025

Going to push as commit a176574.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 24, 2025
@openjdk openjdk bot closed this Jan 24, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jan 24, 2025
@openjdk
Copy link

openjdk bot commented Jan 24, 2025

@mstr2 Pushed as commit a176574.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukostyra lukostyra lukostyra approved these changes

@kevinrushforth kevinrushforth kevinrushforth approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstr2 @kevinrushforth @lukostyra